taiars/nora
1
0
Fork 0
mirror of https://github.com/getnora-io/nora.git synced 2026-04-12 12:40:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(auth): replace starts_with with explicit matches for token paths

Browse Source 
Prevent accidental exposure of unknown /api/tokens/* sub-paths.
Only the three known routes are now explicitly whitelisted in
is_public_path: /api/tokens, /api/tokens/list, /api/tokens/revoke.
This commit is contained in:
devitway
2026-02-22 20:35:04 +00:00
parent 078ef94153
commit ffac4f0286
1 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
nora-registry/src/auth.rs
View File

@@ -63,11 +63,17 @@ impl HtpasswdAuth {
fn is_public_path(path: &str) -> bool { fn is_public_path(path: &str) -> bool {
matches!( matches!(
path, path,
"/" | "/health" | "/ready" | "/metrics" | "/v2/" | "/v2" "/" | "/health"
| "/ready"
| "/metrics"
| "/v2/"
| "/v2"
| "/api/tokens"
| "/api/tokens/list"
| "/api/tokens/revoke"
) || path.starts_with("/ui") ) || path.starts_with("/ui")
|| path.starts_with("/api-docs") || path.starts_with("/api-docs")
|| path.starts_with("/api/ui") || path.starts_with("/api/ui")
|| path.starts_with("/api/tokens")
} }
/// Auth middleware - supports Basic auth and Bearer tokens /// Auth middleware - supports Basic auth and Bearer tokens
@@ -404,8 +410,12 @@ mod tests {
assert!(is_public_path("/api/ui/stats")); assert!(is_public_path("/api/ui/stats"));
assert!(is_public_path("/api/tokens")); assert!(is_public_path("/api/tokens"));
assert!(is_public_path("/api/tokens/list")); assert!(is_public_path("/api/tokens/list"));
assert!(is_public_path("/api/tokens/revoke"));
// Protected paths // Protected paths
assert!(!is_public_path("/api/tokens/unknown"));
assert!(!is_public_path("/api/tokens/admin"));
assert!(!is_public_path("/api/tokens/extra/path"));
assert!(!is_public_path("/v2/myimage/blobs/sha256:abc")); assert!(!is_public_path("/v2/myimage/blobs/sha256:abc"));
assert!(!is_public_path("/v2/library/nginx/manifests/latest")); assert!(!is_public_path("/v2/library/nginx/manifests/latest"));
assert!(!is_public_path( assert!(!is_public_path(