mirror of
https://github.com/getnora-io/nora.git
synced 2026-04-12 05:40:31 +00:00
fix: smoke test image tag v-prefix mismatch (#101)
* fix: smoke test uses semver tag (0.4.0) not git ref (v0.4.0) github.ref_name = v0.4.0 but Docker metadata strips the v prefix, so the image is tagged 0.4.0. Use steps.meta-alpine.outputs.version which matches the actual image tag. * ci: add actionlint to catch workflow syntax errors on PRs Prevents broken release.yml from reaching main. Catches: syntax errors in run scripts, invalid step output references, missing image names, and other GitHub Actions misconfigurations.
This commit is contained in:
3
.github/actionlint.yaml
vendored
Normal file
3
.github/actionlint.yaml
vendored
Normal file
@@ -0,0 +1,3 @@
|
||||
self-hosted-runner:
|
||||
labels:
|
||||
- nora
|
||||
11
.github/workflows/ci.yml
vendored
11
.github/workflows/ci.yml
vendored
@@ -31,6 +31,17 @@ jobs:
|
||||
run: cargo test --package nora-registry
|
||||
|
||||
|
||||
lint-workflows:
|
||||
name: Lint Workflows
|
||||
runs-on: ubuntu-latest
|
||||
steps:
|
||||
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
|
||||
- name: Install actionlint
|
||||
run: bash <(curl -s https://raw.githubusercontent.com/rhysd/actionlint/main/scripts/download-actionlint.bash)
|
||||
- name: Run actionlint
|
||||
run: ./actionlint -ignore "shellcheck reported issue" -ignore "SC[0-9]"
|
||||
|
||||
|
||||
coverage:
|
||||
name: Coverage
|
||||
runs-on: ubuntu-latest
|
||||
|
||||
8
.github/workflows/release.yml
vendored
8
.github/workflows/release.yml
vendored
@@ -136,7 +136,7 @@ jobs:
|
||||
- name: Smoke test — verify alpine image starts and responds
|
||||
run: |
|
||||
docker rm -f nora-smoke 2>/dev/null || true
|
||||
docker run --rm -d --name nora-smoke -p 5555:4000 -e NORA_HOST=0.0.0.0 ghcr.io/${{ github.repository }}:${{ github.ref_name }}
|
||||
docker run --rm -d --name nora-smoke -p 5555:4000 -e NORA_HOST=0.0.0.0 ghcr.io/${{ github.repository }}:${{ steps.meta-alpine.outputs.version }}
|
||||
for i in $(seq 1 10); do
|
||||
curl -sf http://localhost:5555/health && break || sleep 2
|
||||
done
|
||||
@@ -299,17 +299,17 @@ jobs:
|
||||
|
||||
**Alpine (standard):**
|
||||
```bash
|
||||
docker pull ghcr.io/${{ github.repository }}:${{ github.ref_name }}
|
||||
docker pull ghcr.io/${{ github.repository }}:${{ steps.ver.outputs.tag }}
|
||||
```
|
||||
|
||||
**RED OS:**
|
||||
```bash
|
||||
docker pull ghcr.io/${{ github.repository }}:${{ github.ref_name }}-redos
|
||||
docker pull ghcr.io/${{ github.repository }}:${{ steps.ver.outputs.tag }}-redos
|
||||
```
|
||||
|
||||
**Astra Linux SE:**
|
||||
```bash
|
||||
docker pull ghcr.io/${{ github.repository }}:${{ github.ref_name }}-astra
|
||||
docker pull ghcr.io/${{ github.repository }}:${{ steps.ver.outputs.tag }}-astra
|
||||
```
|
||||
|
||||
## Changelog
|
||||
|
||||
Reference in New Issue
Block a user